Make retrieval of parameters more robust in Frame python bindings #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In which cases can you have set but empty parameters? |
|
That came up during the LCIO -> EDM4hep conversion. Not sure why, but there are cases where there are parameter keys without any non-empty value associated to it. |
jmcarcell
approved these changes
May 30, 2023
There was a problem hiding this comment.
Without being able to reproduce it looks good, the bug is quite obvious when pointed out. As long as the returned parameters are in a list (even an empty list) this will work fine
EDIT: I was able to reproduce independently and can confirm this fixes the issue
tmadlener
added a commit
that referenced
this pull request
Jul 13, 2023
* Make retrieval of parameters more robust in Frame python bindings (#422) * Make ROOTLegacyReader handle older versions correctly * Fix reading of v00-16 files and adapt tests to expected contents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
podio-dumpwhen trying to access a non-existent elementENDRELEASENOTES